Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining references to the travel pay ping endpoints #18353

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

liztownd
Copy link
Contributor

@liztownd liztownd commented Sep 6, 2024

Summary

  • This work is behind a feature toggle (flipper): YES
  • (Summarize the changes that have been made to the platform)
    • Remove the last few remaining references to the travel pay ping endpoints
    • (missed a few function defs in the process of removing the endpoints, this is code cleanup)

Related issue(s)

Testing done

  • New code is covered by unit tests
    • Tests already removed

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

  • Travel Pay Module

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@kjduensing kjduensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I missed those as well. Good catch

Copy link

github-actions bot commented Sep 9, 2024

Backend-review-group approval confirmed.

@liztownd liztownd merged commit 7453ccf into master Sep 9, 2024
29 of 30 checks passed
@liztownd liztownd deleted the liz-btsss/remove-travel-pay-pings branch September 9, 2024 14:48
gabezurita added a commit that referenced this pull request Sep 9, 2024
* master:
  case9 logic fixed (#18362)
  API-39748-add-index-to-error-collection-messages (#18333)
  Use random value in Simple Forms PDF stamping file paths (#18361)
  Add `find_dependents_by_ptcpnt_id` to local bgs (#18303)
  remove request_ping defs (#18353)
  API-38827-update-validations-intl-postal-code (#18323)
  [Document Upload Failure] Email veteran on Form 0781/Form 0781a upload retry exhaustion (#18206)
  add feature flags for meb and 5490 (#18328)
  Handle 500 responses from VA Profile v3 Service for v0/profile/contacts endpoint (#18192)
  Resolve MethodLength Rubocop Disables - Part 3 (#18331)
  Resolve MethodLength Rubocop Disables - Part BGS::Form674 (#18326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants